-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Dependencies: -" if there are no dependencies (instead of "Dependenc… #438
Conversation
Cool, thanks for jumping on this! What do you think of changing it to something like |
src/lsp/MessageHandlers.re
Outdated
let depsString = depsList == [] ? "-" : String.concat(", ", depsList) | ||
let lenses = (state.settings.dependenciesCodelens==true) ? [("Dependencies: " ++ depsString, topLoc), ...lenses] : lenses; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let depsString = depsList == [] ? "-" : String.concat(", ", depsList) | |
let lenses = (state.settings.dependenciesCodelens==true) ? [("Dependencies: " ++ depsString, topLoc), ...lenses] : lenses; | |
let depsString = depsList == [] ? "This file has no dependencies" : ("Dependencies: " ++ String.concat(", ", depsList)) | |
let lenses = (state.settings.dependenciesCodelens==true) ? [(depsString, topLoc), ...lenses] : lenses; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we keep the additional text output minimalistic in this case please, since it affects the file header line and people read this so often; less is more, less prevents distracting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm sure that's fine -- I just think the " - " is almost as confusing as not having anything. What about Dependencies: [none]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be nice :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reworked this corresponding to your proposal in a new commit, same PR.
feature request issue #437
adjust the grey colored CodeLens label/information:
"Dependencies: -" if there are no dependencies (instead of "Dependencies:")