pkp#10670 Use new url for workflow page

jardakotesovec · Jan 8, 2025 · 2762150 · 2762150
1 parent d15e998
commit 2762150
Show file tree

Hide file tree

Showing 11 changed files with 45 additions and 31 deletions.
diff --git a/classes/mail/mailables/EditorialReminder.php b/classes/mail/mailables/EditorialReminder.php
@@ -72,9 +72,10 @@ public function setOutstandingTasks(array $outstanding, array $submissions, int
                 Application::get()->getRequest(),
                 Application::ROUTE_PAGE,
                 $this->context->getPath(),
-                'workflow',
-                'access',
-                [$submission->getId()]
+                'dashboard',
+                'editorial',
+                null,
+                ['workflowSubmissionId' => $submission->getId()]
             );
 
             $outstandingTasks[] = '

diff --git a/classes/mail/variables/SubmissionEmailVariable.php b/classes/mail/variables/SubmissionEmailVariable.php
@@ -127,9 +127,10 @@ protected function getSubmissionUrl(Context $context): string
             $request,
             PKPApplication::ROUTE_PAGE,
             $context->getData('urlPath'),
-            'workflow',
-            'access',
-            [$this->submission->getId()]
+            'dashboard',
+            'editorial',
+            null,
+            ['workflowSubmissionId' => $this->submission->getId()]
         );
     }
 

diff --git a/classes/notification/PKPNotificationManager.php b/classes/notification/PKPNotificationManager.php
@@ -59,7 +59,7 @@ public function getNotificationUrl(PKPRequest $request, Notification $notificati
                 if ($notification->assocType != Application::ASSOC_TYPE_SUBMISSION) {
                     throw new \Exception('Unexpected assoc type!');
                 }
-                return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'workflow', 'access', [$notification->assocId]);
+                return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'dashboard', 'editorial', null, ['workflowSubmissionId' => $notification->assocId]);
             case Notification::NOTIFICATION_TYPE_REVIEWER_COMMENT:
                 if ($notification->assocType != Application::ASSOC_TYPE_REVIEW_ASSIGNMENT) {
                     throw new \Exception('Unexpected assoc type!');

diff --git a/classes/notification/managerDelegate/PKPApproveSubmissionNotificationManager.php b/classes/notification/managerDelegate/PKPApproveSubmissionNotificationManager.php
@@ -32,7 +32,7 @@ public function getNotificationUrl(PKPRequest $request, Notification $notificati
     {
         $dispatcher = Application::get()->getDispatcher();
         $context = $request->getContext();
-        return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'workflow', 'access', [$notification->assocId]);
+        return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'dashboard', 'editorial', null, ['workflowSubmissionId' => $notification->assocId]);
     }
 
     /**

diff --git a/classes/notification/managerDelegate/PKPEditingProductionStatusNotificationManager.php b/classes/notification/managerDelegate/PKPEditingProductionStatusNotificationManager.php
@@ -60,7 +60,7 @@ public function getNotificationUrl(PKPRequest $request, Notification $notificati
                 if ($notification->assocType != Application::ASSOC_TYPE_SUBMISSION) {
                     throw new \Exception('Unexpected assoc type for notification!');
                 }
-                return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'workflow', 'access', [$notification->assocId]);
+                return $dispatcher->url($request, PKPApplication::ROUTE_PAGE, $context->getPath(), 'dashboard', 'editorial', null, ['workflowSubmissionId' => $notification->assocId]);
         }
         throw new \Exception('Unmatched notification type!');
     }

diff --git a/classes/services/PKPNavigationMenuService.php b/classes/services/PKPNavigationMenuService.php
@@ -300,14 +300,11 @@ public function getDisplayStatus(&$navigationMenuItem, &$navigationMenu)
                     break;
                 case NavigationMenuItem::NMI_TYPE_USER_DASHBOARD:
                     if ($currentUser->hasRole([Role::ROLE_ID_MANAGER, Role::ROLE_ID_ASSISTANT, Role::ROLE_ID_REVIEWER, Role::ROLE_ID_AUTHOR], $contextId) || $currentUser->hasRole([Role::ROLE_ID_SITE_ADMIN], PKPApplication::SITE_CONTEXT_ID)) {
-                        $navigationMenuItem->setUrl($dispatcher->url(
-                            $request,
-                            PKPApplication::ROUTE_PAGE,
-                            null,
-                            'submissions',
-                            null,
-                            null
-                        ));
+                        $pkpPageRouter = $request->getRouter();  /** @var \PKP\core\PKPPageRouter $pkpPageRouter */
+                        $pkpPageRouter->getHomeUrl($request);
+
+
+                        $navigationMenuItem->setUrl($pkpPageRouter->getHomeUrl($request));
                     } else {
                         $navigationMenuItem->setUrl($dispatcher->url(
                             $request,

diff --git a/controllers/grid/users/stageParticipant/StageParticipantGridHandler.php b/controllers/grid/users/stageParticipant/StageParticipantGridHandler.php
@@ -147,9 +147,10 @@ public function initialize($request, $args = null)
                 $request,
                 PKPApplication::ROUTE_PAGE,
                 null,
-                'workflow',
-                'access',
-                [$submissionId]
+                'dashboard',
+                'editorial',
+                null,
+                ['workflowSubmissionId' => $submissionId]
             );
             $this->addAction(
                 new LinkAction(

diff --git a/pages/authorDashboard/PKPAuthorDashboardHandler.php b/pages/authorDashboard/PKPAuthorDashboardHandler.php
@@ -29,6 +29,7 @@
 use PKP\components\forms\publication\PKPMetadataForm;
 use PKP\components\forms\publication\TitleAbstractForm;
 use PKP\components\listPanels\ContributorsListPanel;
+use PKP\config\Config;
 use PKP\context\Context;
 use PKP\core\JSONMessage;
 use PKP\core\PKPApplication;
@@ -91,6 +92,13 @@ public function authorize($request, &$args, $roleAssignments)
      */
     public function submission($args, $request)
     {
+        if (Config::getVar('features', 'enable_new_submission_listing')) {
+            $submission = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_SUBMISSION);
+            $router = $request->getRouter();
+            return $request->redirectUrl($router->url($request, null, 'dashboard', 'mySubmissions', null, ['workflowSubmissionId' => $submission->getId()]));
+        }
+
+
         // Pass the authorized submission on to the template.
         $this->setupTemplate($request);
 

diff --git a/pages/decision/DecisionHandler.php b/pages/decision/DecisionHandler.php
@@ -162,9 +162,10 @@ public function record($args, $request)
                 $request,
                 Application::ROUTE_PAGE,
                 $context->getData('urlPath'),
-                'workflow',
-                'access',
-                [$this->submission->getId()]
+                'dashboard',
+                'editorial',
+                null,
+                ['workflowSubmissionId' => $this->submission->getId()]
             ),
             'submissionApiUrl' => $dispatcher->url(
                 $request,
@@ -237,9 +238,10 @@ protected function getBreadcrumb(Submission $submission, Context $context, Reque
                     $request,
                     Application::ROUTE_PAGE,
                     $context->getData('urlPath'),
-                    'workflow',
-                    'access',
-                    [$submission->getId()]
+                    'dashboard',
+                    'editorial',
+                    null,
+                    ['workflowSubmissionId' => $submission->getId()]
                 ),
             ],
             [

diff --git a/pages/workflow/PKPWorkflowHandler.php b/pages/workflow/PKPWorkflowHandler.php
@@ -106,6 +106,7 @@ public function authorize($request, &$args, $roleAssignments)
      */
     public function access($args, $request)
     {
+
         $submission = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_SUBMISSION);
 
         $currentStageId = $submission->getData('stageId');
@@ -149,6 +150,14 @@ public function access($args, $request)
      */
     public function index($args, $request)
     {
+
+        if (Config::getVar('features', 'enable_new_submission_listing')) {
+            $submission = $this->getAuthorizedContextObject(Application::ASSOC_TYPE_SUBMISSION);
+            $router = $request->getRouter();
+            return $request->redirectUrl($router->url($request, null, 'dashboard', 'editorial', null, ['workflowSubmissionId' => $submission->getId()]));
+        }
+
+
         $this->setupTemplate($request);
         $templateMgr = TemplateManager::getManager($request);
 

diff --git a/templates/layouts/backend.tpl b/templates/layouts/backend.tpl
@@ -128,11 +128,6 @@
 							{/if}
 							<div class="pkpDropdown__section">
 								<ul>
-									<li v-if="backToDashboardLink">
-										<a :href="backToDashboardLink.url" class="pkpDropdown__action">
-											{{ backToDashboardLink.name }}
-										</a>
-									</li>
 									<li>
 										<a href="{url router=PKP\core\PKPApplication::ROUTE_PAGE page="user" op="profile"}" class="pkpDropdown__action">
 											{translate key="user.profile.editProfile"}