Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add episode.original_filename template variable #57

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

janw
Copy link
Owner

@janw janw commented Jan 20, 2024

No description provided.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e4b3eaa) 89.79% compared to head (993f0f7) 91.36%.

Files Patch % Lines
podcast_archiver/models.py 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   89.79%   91.36%   +1.56%     
==========================================
  Files          15       15              
  Lines         578      602      +24     
  Branches       93       99       +6     
==========================================
+ Hits          519      550      +31     
+ Misses         39       35       -4     
+ Partials       20       17       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janw janw force-pushed the add-original-filename-var branch 2 times, most recently from 7250f44 to b4e1875 Compare January 20, 2024 13:39
) and link.href.host != quirks.INVALID_URL_PLACEHOLDER:
self.media_link = link
return self
def populate_from_enclosure(self) -> Episode:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function populate_from_enclosure has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.

@janw janw force-pushed the add-original-filename-var branch 2 times, most recently from 006c321 to 4f0832c Compare January 20, 2024 14:07
Copy link

codeclimate bot commented Jan 20, 2024

Code Climate has analyzed commit 993f0f7 and detected 0 issues on this pull request.

View more on Code Climate.

@janw janw merged commit 0e1be70 into main Jan 20, 2024
12 of 13 checks passed
@janw janw deleted the add-original-filename-var branch January 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant