Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve failure handling and logging #189

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

janw
Copy link
Owner

@janw janw commented Oct 20, 2024

Fixes #134, fixes #129.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 78.18182% with 12 lines in your changes missing coverage. Please review.

Project coverage is 91.26%. Comparing base (406f119) to head (84afd57).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
podcast_archiver/utils.py 55.00% 7 Missing and 2 partials ⚠️
podcast_archiver/logging.py 66.66% 1 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   91.12%   91.26%   +0.13%     
==========================================
  Files          15       15              
  Lines         744      767      +23     
  Branches      133      137       +4     
==========================================
+ Hits          678      700      +22     
  Misses         46       46              
- Partials       20       21       +1     
Files with missing lines Coverage Δ
podcast_archiver/base.py 92.30% <100.00%> (-0.20%) ⬇️
podcast_archiver/cli.py 82.10% <100.00%> (ø)
podcast_archiver/download.py 93.42% <100.00%> (+0.08%) ⬆️
podcast_archiver/processor.py 96.38% <100.00%> (+7.96%) ⬆️
podcast_archiver/session.py 100.00% <100.00%> (ø)
podcast_archiver/logging.py 72.72% <66.66%> (+10.22%) ⬆️
podcast_archiver/utils.py 89.02% <55.00%> (-10.98%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Oct 20, 2024

Code Climate has analyzed commit 84afd57 and detected 0 issues on this pull request.

View more on Code Climate.

@janw janw merged commit 80e41d8 into main Oct 20, 2024
13 of 14 checks passed
@janw janw deleted the improve-failure-logging branch October 20, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS errors don't recover UI issues when downloading multiple feeds?
1 participant