Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix: install dynamic plugins in an ephemeral generic volume by default #149

Merged

Conversation

davidfestal
Copy link
Member

Description of the change

Install dynamic plugins in an ephemeral generic volume by default, instead of an emptyDir which offers no serious storage configuration options.

Existing or Associated Issue(s)

#146

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@davidfestal davidfestal requested review from a team and tumido November 13, 2023 14:03
@davidfestal davidfestal force-pushed the dynamic-plugins-in-ephemeral-volume branch from 0d6d7c3 to 8629fcd Compare November 13, 2023 14:06
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tumido tumido merged commit bcc10aa into janus-idp:main Nov 13, 2023
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a PVC-based generic ephemeral volume to store dynamic plugins by default, instead of an emptyDir.
2 participants