Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error messages for simple cases #45

Merged
merged 4 commits into from
Jan 17, 2024
Merged

add error messages for simple cases #45

merged 4 commits into from
Jan 17, 2024

Conversation

jantimon
Copy link
Owner

This PR detects very simple error cases:

styled.button`
  &:focus { ${myMixn} }
`

it detects the mistake by checking if the expression is a variable

This will not detect errors from inlined arrow functions:

styled.button`
  &:focus { ${() => myMixn} }
`

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 2:51pm

Copy link

codspeed-hq bot commented Jan 17, 2024

CodSpeed Performance Report

Merging #45 will not alter performance

Comparing feature/error-messages (ce6e00a) with main (840b2a5)

Summary

✅ 2 untouched benchmarks

@Mad-Kat Mad-Kat merged commit 658b730 into main Jan 17, 2024
6 checks passed
@jantimon jantimon deleted the feature/error-messages branch January 17, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants