Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested CSS Expressions #44

Merged
merged 15 commits into from
Jan 16, 2024
Merged

Nested CSS Expressions #44

merged 15 commits into from
Jan 16, 2024

Conversation

rvetere
Copy link
Collaborator

@rvetere rvetere commented Jan 15, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jan 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yacijs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 3:33pm

@rvetere rvetere changed the title Initial commit Nested CSS Expressions Jan 15, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #44 will not alter performance

Comparing feature/nested-css-expressions (2dcf141) with main (a7613d4)

Summary

✅ 2 untouched benchmarks

@jantimon
Copy link
Owner

jantimon commented Jan 15, 2024 •
edited
Loading

Todos:

  • ts-loader - Allow using expressions inside nestings (remove Expressions are not allowed inside nested selectors error in those cases)
  • ts-loader - Add styled. component class name even for nested css e.g.:
css`
  ${x > 0.5 && css`
    color: blue;
  `}
`

@jantimon jantimon marked this pull request as ready for review January 16, 2024 15:40
@jantimon jantimon self-requested a review January 16, 2024 15:40
@jantimon jantimon merged commit fe9dc90 into main Jan 16, 2024
6 checks passed
@jantimon jantimon deleted the feature/nested-css-expressions branch February 7, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jantimon jantimon jantimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvetere @jantimon