Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework resolving #144

Merged
merged 6 commits into from
Aug 2, 2024
Merged

rework resolving #144

merged 6 commits into from
Aug 2, 2024

Conversation

jantimon
Copy link
Owner

  1. Improved Caching Strategy:

    • Cache keys now use resolved paths for more reliable caching across different import scenarios.
  2. Recursive Resolution Improvements:

    • As soon as a reexport is form a .yak file the file is evaluated
  3. Support for Star Exports:

    • Added ability to follow 'export * from' statements (when it's the only star export and the identifier wasn't found elsewhere)
  4. Enhanced Error Handling:

    • Improved error messages throughout the code, providing more context about where errors occur

Fixes #142

Copy link

codspeed-hq bot commented Jul 26, 2024

CodSpeed Performance Report

Merging #144 will not alter performance

Comparing feature/css-yak-recursion (7702564) with main (0da74a2)

Summary

✅ 2 untouched benchmarks

@jantimon jantimon requested a review from Mad-Kat July 29, 2024 09:25
Mad-Kat
Mad-Kat previously approved these changes Jul 29, 2024
packages/next-yak/loaders/lib/resolveCrossFileSelectors.ts Outdated Show resolved Hide resolved
@jantimon jantimon merged commit 4a7ff24 into main Aug 2, 2024
6 checks passed
@jantimon jantimon deleted the feature/css-yak-recursion branch August 2, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance CSS constant import resolution
2 participants