add toggleClass parameter for setClassToggle

[kasparsj]

when set to true will use toggleClass, rather than addClass/removeClass

[janpaepke]

Hi @kasparsj !

Why should this be an option? In theory both behaviours should be the same, no?
If jquery toggle logic is better maybe remove addclass/removeclass alltogether?

[kasparsj]

Hi @kasparsj !

Why should this be an option? In theory both behaviours should be the same, no?
If jquery toggle logic is better maybe remove addclass/removeclass alltogether?

It's a long time since... but I think, I found it more useful to use toggleClass, maybe there was no other way to detect whether the class is on or off.
I think these are different behaviours actually, and cannot do what the other can...

[janpaepke]

I think these are different behaviours actually, and cannot do what the other can...

Could you elaborate? How exactly are the behaviours different?

[kasparsj]

the first will always "addClass" on "enter", and "removeClass" on "leave".

the second can do opposite (remove on enter, add on leave), and it can also work in conjunction with another logic (if another logic is also toggling the classes on/off).

[janpaepke]

mh you raise a very good point.

But shouldn't this be default behaviour? Unless I'm forgetting something the current behaviour would still work with your toggle-class function.
So replacing it would be a non-breaking change, right?
What do you think?

[kasparsj]

Yes, I think it should be the default behaviour, but maybe having the current behaviour can also be handy in certain cases.

[janpaepke]

but that's kind of my point. I get that using "real" toggle adds functionality, as you could invert the logic.
But I don't think entirely replacing the current function would remove anything, as it would still work the same.
I'm trying to think of a scenario where you don't want toggle and actually want to use add and remove class for whatever reason. I can't think of any. Can you?

[kasparsj]

No, I can't think of any good example right now...

[janpaepke]

I think we should change the behaviour alltogether then.
I'll put it on the list for the next release.
This will also mean some documentation adjustments so won't be asking this of you. :)
I'll leave this open until I get around to attend to it.