Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ux edit message and copy api_key #3975

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: ux edit message and copy api_key #3975

merged 1 commit into from
Nov 8, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Nov 7, 2024

Describe Your Changes

  1. Edit Message will always make cursor input on latest length
  2. Issue unable copy api_key, update icon also, when copied will show checklist
  3. Update Toggle icon EyeOnIcon / EyeOffIcon

Fixes Issues

#3911 (comment)
#3911 (comment)

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Nov 7, 2024
@urmauur urmauur added this to the v0.5.8 milestone Nov 7, 2024
@urmauur urmauur requested review from louis-jan and a team November 7, 2024 14:37
@urmauur urmauur self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Barecheck - Code coverage report

Total: 69.58%

Your code coverage diff: -0.02% ▾

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/EditChatInput/index.tsx40-42, 44-51, 53-54, 57-61, 65-69, 74-75, 79-85, 93, 98-103, 107-108, 141, 149, 157, 160

@urmauur urmauur merged commit 5271c9f into dev Nov 8, 2024
11 checks passed
@urmauur urmauur deleted the fix/minor-ui-0.5.8 branch November 8, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.5.8
Development

Successfully merging this pull request may close these issues.
2 participants
@urmauur @louis-jan