Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toolbar overlap chat input #3720

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: toolbar overlap chat input #3720

merged 1 commit into from
Sep 23, 2024

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Sep 23, 2024

Describe Your Changes

  • Fix toolbar chat input overlap
Screenshot 2024-09-23 at 13 53 25 Screenshot 2024-09-23 at 13 53 11 Screenshot 2024-09-23 at 13 54 06 Screenshot 2024-09-23 at 13 53 54

Known Issue

We are using bg-textarea for our toolbar because the textarea is on the right panel and needs a blur effect.
That’s why we don’t set a background for the textarea, instead, the toolbar background should match the center panel.

The code changes only update the background class for the toolbar element and reposition the toolbar to fit with the chat input, as the toolbar is positioned absolutely

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Sep 23, 2024
@urmauur urmauur added this to the v0.5.5 milestone Sep 23, 2024
@urmauur urmauur self-assigned this Sep 23, 2024
@louis-jan
Copy link
Contributor

LGTM

Copy link
Contributor

Barecheck - Code coverage report

Total: 60.07%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/screens/Thread/ThreadCenterPanel/ChatInput/index.tsx78, 82, 90-91, 109, 112-113, 119-123, 128, 141-143, 147-149, 154, 157, 190, 196, 198, 265, 268-269, 294, 298-299, 339, 362, 414-416, 418-420, 422-424, 426, 430-431, 467

@urmauur urmauur merged commit 15f42fb into dev Sep 23, 2024
11 checks passed
@urmauur urmauur deleted the fix/chat-input branch September 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Input text overlaps model settings
2 participants