Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Copyfix #3694

Merged
merged 8 commits into from
Sep 19, 2024
Merged

chore: Copyfix #3694

merged 8 commits into from
Sep 19, 2024

Conversation

0xSage
Copy link
Contributor

@0xSage 0xSage commented Sep 18, 2024

Describe Your Changes

  • copy nits

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@0xSage 0xSage requested a review from urmauur September 18, 2024 09:03
@github-actions github-actions bot added the type: chore Maintenance, operational label Sep 18, 2024
@0xSage
Copy link
Contributor Author

0xSage commented Sep 18, 2024

@urmauur is yarn linter --fix a different linter than in our CI?

I ran

❯ yarn lint --fix
yarn run v1.22.22
$ yarn workspace jan lint && yarn workspace @janhq/web lint --fix
$ eslint . --ext ".js,.jsx,.ts,.tsx"
$ eslint . --fix
✨  Done in 6.47s.

But still failing the github pr linter. 🙏

@urmauur
Copy link
Member

urmauur commented Sep 19, 2024

@urmauur is yarn linter --fix a different linter than in our CI?

I ran

❯ yarn lint --fix
yarn run v1.22.22
$ yarn workspace jan lint && yarn workspace @janhq/web lint --fix
$ eslint . --ext ".js,.jsx,.ts,.tsx"
$ eslint . --fix
✨  Done in 6.47s.

But still failing the github pr linter. 🙏

i'll take a look this @0xSage

Copy link
Contributor

Barecheck - Code coverage report

Total: 57.49%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

@0xSage 0xSage merged commit 17be901 into dev Sep 19, 2024
8 of 9 checks passed
@0xSage 0xSage deleted the copyfix branch September 19, 2024 03:32
@github-actions github-actions bot added this to the v0.5.5 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants