Fix: #1142 setting groups toggle does not turn off it's nested settings #3681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an app bug where it does not reset other settings when the experimental feature is toggled off.
Two of the major changes:
e.target.checked
instead ofe
)Scenarios:
Bug fix:
It should toggle off features gated by Experimental Settings when toggling off.
Regarding the issue where app could not get Vulkan device VRAM which is not scoped by the issue, it should be a part of janhq/cortex.cpp#1165
Fixes Issues
Changes made
Added components and attributes:
Switch
component inside theonExperimentalFeature
section to help with testing.data-testid
attribute was added to theproxy-switch
andproxy-input
components inside theonProxy
section to help with testing.data-testid
attribute was added to theignore-ssl-switch
component inside theonIgnoreSSL
section to help with testing.data-testid
attribute was added to thequick-ask-switch
component inside theonQuickAskEnabled
section to help with testing.data-testid
attribute was added to theclear-logs
button component to help with testing.clear-logs
button received a new implementation of theButton
component with adestructive
theme.toggle
function was added to handle click outside functionality.hideDropdown
function was removed, likely due to being unused.Updated functions:
updateExperimentalEnabled
function was modified to not reset other settings when updating experimental enabled.handleGPUChange
function was modified to remove the GPU from thegpusInUse
state when it's removed.updateQuickAskEnabled
function was implemented to update quick ask enabled.updateVulkanEnabled
function was implemented to update vulkan enabled.clearLogs
function was implemented to clear logs.Removed unnecessary code:
test
) with two GPU objects was removed as it's no longer used in the component.gpusInUse
state was initialized as an empty array.Miscellaneous:
Self Checklist