Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change jan default data folder path to app's userData #3443

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Aug 22, 2024

Describe Your Changes

Currently, we are setting the Jan default data folder path to the user's home directory. It would be better to change it back to the app's appData folder, which is defined by the OS and used by the Electron app.

appData Per-user application data directory, which by default points to:
%APPDATA% on Windows
$XDG_CONFIG_HOME or ~/.config on Linux
~/Library/Application Support on macOS
userData The directory for storing your app's configuration files, which by default is the appData directory appended with your app's name. By convention files storing user data should be written to this directory, and it is not recommended to write large files here because some environments may backup this directory to cloud storage.

https://www.electronjs.org/docs/latest/api/app

So when a user does a fresh install of Jan, they will see Jan under ~/[Jan app data]/jan. They can delete either only the Jan user data folder or the entire Jan app data folder.

Also fixed an issue where users could not reset the path on the latest stable release.

Jan Data Folder Settings
Screenshot 2024-08-22 at 17 34 34
Screenshot 2024-08-23 at 14 08 05

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: chore Maintenance, operational label Aug 22, 2024
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 925cd04 into dev Aug 23, 2024
7 checks passed
@Van-QA Van-QA deleted the chore/change-default-jan-data-folder-to-app-user-data branch August 23, 2024 12:21
@github-actions github-actions bot added this to the v.0.6.0 milestone Aug 23, 2024
@Van-QA Van-QA mentioned this pull request Aug 26, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Maintenance, operational
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants