-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planning: Jan's path to cortex.cpp? #3690
Comments
Bundled EnginesIs it possible that, E.g. So:
Eventually, that's all it needs to work with – the Model ID (aka model name).
|
Incremental Path
sequenceDiagram
participant App as "App"
participant Models as "Models"
participant ModelList as "Model List"
participant ModelYaml as "Model YAML"
App->>Models: import
activate Models
Models->>ModelList: update models.list
activate ModelList
ModelList->>Models: return data
deactivate ModelList
Models->>ModelYaml: generate (async)
activate ModelYaml
Note right of ModelYaml: generate model.yaml asynchronously
ModelYaml->>Models: (async) generated
deactivate ModelYaml
deactivate Models
|
This is really well thought through. Questions @louis-jan :
|
@0xSage All great questions, related issue that we discussed Hardware Info endpoint. janhq/cortex.cpp#1165 (comment)
The one blocking this is download progress sync, which we aligned with a socket approach. |
Nice, always great when the best answer is the simplest!! 🙏
…On Mon, Sep 30, 2024 at 10:35 AM Louis ***@***.***> wrote:
@0xSage <https://github.com/0xSage> All great questions, related issue
that we discussed Hardware Info endpoint. janhq/cortex.cpp#1165 (comment)
<janhq/cortex.cpp#1165 (comment)>
2. Jan does not let users change hardware level configuration but
Engine settings (CPU/GPU mode, CPU threads ...)
3. Engine status and model status were previously supported in
cortex.cpp, but I don't see a clear use case from Jan's work, such as
implementing a switch or update mechanism for the engine.
4. /healthcheck is needed, and implemented from cortex.cpp
The one blocking this is download progress sync, which we aligned with a
socket approach.
—
Reply to this email directly, view it on GitHub
<#3690 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQVWFCD6FUKNF7B3EWM42Q3ZZC2IBAVCNFSM6AAAAABOLJYFMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBRHA4DQOBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Package cortex.cpp into Jan app:
Pros
Cons
cortex.cpp configurations on spawn
|
Seamless Models Imports & RunSince we no longer use
This operation runs asynchronously, won't affect the UX, since it works with cached data. Even the model is not imported yet, it should still function normally (with stateless model load endpoint). There will be a door for broken requests or attempts. In case users are updating from a very old version, we run a scan on model.json and persist the cache (as the current - legacy logics) -> Continue with (1) |
Current issues being faced:
|
@dan-homebrew: will create an Implementation Issue: |
Goal
nitro-extension
, andcortex-extension
?)Tasklist
The text was updated successfully, but these errors were encountered: