Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Jan supports new Cortex's Model Folder and model.yaml architecture #3633

Closed
Tracked by #3825
dan-homebrew opened this issue Sep 11, 2024 · 1 comment
Closed
Tracked by #3825

feat: Jan supports new Cortex's Model Folder and model.yaml architecture #3633

dan-homebrew opened this issue Sep 11, 2024 · 1 comment
Assignees
@louis-jan
Labels
category: cortex.cpp Related to cortex.cpp category: model hub Built in models, latest HF models page P1: important Important feature / fix

Comments

@dan-homebrew
Copy link
Contributor

dan-homebrew commented Sep 11, 2024 •
edited
Loading

Goal

  • Sub-task of planning: Jan's path to cortex.cpp? #3690
  • Jan should support new Model folder and model.yaml architecture from cortex.cpp
  • Jan should be able to migrate up/down, and deal with migration errors
  • Migration safety should be assured via adequate tests on different OS and hardware

Key Questions

  • What is the strategy? Migration, or just handling old models as "legacy"? (and keeping nitro extension)
  • For migration:
    • Is this handled at cortex.cpp or at Jan?
    • Does cortex.cpp need to have a POST /migrations API?
  • For supporting legacy models:
    • Can Jan just have a legacy FS adapter to handle legacy model folder and model.json (how can it be detected?)
    • How do we cover this with sufficient test cases to make sure future intern does not blow it up?

Related
@dan-homebrew dan-homebrew added the type: epic A major feature or initiative label Sep 11, 2024
@dan-homebrew dan-homebrew mentioned this issue Sep 11, 2024
Closed
@dan-homebrew dan-homebrew mentioned this issue Sep 13, 2024
Merged
3 tasks
@imtuyethan imtuyethan added the category: model hub Built in models, latest HF models page label Sep 18, 2024
@0xSage 0xSage added P1: important Important feature / fix category: local engines category: cortex.cpp Related to cortex.cpp labels Oct 13, 2024
@dan-homebrew dan-homebrew changed the title epic: Jan supports new Model Folder and model.yaml architecture discussion: Jan supports new Model Folder and model.yaml architecture Oct 17, 2024
@dan-homebrew dan-homebrew changed the title discussion: Jan supports new Model Folder and model.yaml architecture discussion: Jan supports new Cortex's Model Folder and model.yaml architecture Oct 17, 2024
@dan-homebrew dan-homebrew changed the title discussion: Jan supports new Cortex's Model Folder and model.yaml architecture feat: Jan supports new Cortex's Model Folder and model.yaml architecture Oct 17, 2024
@0xSage 0xSage removed the type: epic A major feature or initiative label Oct 17, 2024
@0xSage 0xSage mentioned this issue Oct 17, 2024
Closed
2 tasks
@imtuyethan imtuyethan mentioned this issue Oct 18, 2024
Open
@dan-homebrew
Copy link
Contributor Author

Merging into #3825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-jan louis-jan

Labels
category: cortex.cpp Related to cortex.cpp category: model hub Built in models, latest HF models page P1: important Important feature / fix
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nguyenhoangthuan99 @0xSage @imtuyethan @dan-homebrew @louis-jan