fix: max_tokens and ctx_len max value will follow model.json (#2961)

Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]>
janhq · May 29, 2024 · 540999c · 540999c
1 parent faa09bd
commit 540999c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 17 deletions.
diff --git a/web/containers/ModelSetting/SettingComponent.tsx b/web/containers/ModelSetting/SettingComponent.tsx
@@ -3,17 +3,12 @@ import {
   InputComponentProps,
   CheckboxComponentProps,
   SliderComponentProps,
-  InferenceEngine,
 } from '@janhq/core'
 
-import { useAtomValue } from 'jotai/react'
-
 import Checkbox from '@/containers/Checkbox'
 import ModelConfigInput from '@/containers/ModelConfigInput'
 import SliderRightPanel from '@/containers/SliderRightPanel'
 
-import { activeThreadAtom } from '@/helpers/atoms/Thread.atom'
-
 type Props = {
   componentProps: SettingComponentProps[]
   disabled?: boolean
@@ -25,7 +20,6 @@ const SettingComponent: React.FC<Props> = ({
   disabled = false,
   onValueUpdated,
 }) => {
-  const activeThread = useAtomValue(activeThreadAtom)
   const components = componentProps.map((data) => {
     switch (data.controllerType) {
       case 'slider': {
@@ -37,16 +31,7 @@ const SettingComponent: React.FC<Props> = ({
             title={data.title}
             description={data.description}
             min={min}
-            max={
-              data.key === 'max_tokens' &&
-              activeThread &&
-              activeThread.assistants[0].model.engine === InferenceEngine.nitro
-                ? Number(
-                    activeThread &&
-                      activeThread.assistants[0].model.settings.ctx_len
-                  )
-                : max
-            }
+            max={max}
             step={step}
             value={value}
             name={data.key}

diff --git a/web/utils/predefinedComponent.ts b/web/utils/predefinedComponent.ts
@@ -36,7 +36,7 @@ export const presetConfiguration: Record<string, SettingComponentProps> = {
       min: 128,
       max: 4096,
       step: 128,
-      value: 2048,
+      value: 4096,
     },
     requireModelReload: true,
     configType: 'setting',