fix: cannot cancel model which is progress at 0 percent (#2727)

Signed-off-by: James <[email protected]> Co-authored-by: James <[email protected]>
janhq · Apr 15, 2024 · 20657bb · 20657bb
1 parent f464131
commit 20657bb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/core/src/node/api/processors/download.ts b/core/src/node/api/processors/download.ts
@@ -66,6 +66,7 @@ export class Downloader implements Processor {
       localPath: normalizedPath,
     }
     DownloadManager.instance.downloadProgressMap[modelId] = initialDownloadState
+    DownloadManager.instance.downloadInfo[normalizedPath] = initialDownloadState
 
     if (downloadRequest.downloadType === 'extension') {
       observer?.(DownloadEvent.onFileDownloadUpdate, initialDownloadState)
@@ -118,12 +119,14 @@ export class Downloader implements Processor {
     if (rq) {
       DownloadManager.instance.networkRequests[fileName] = undefined
       rq?.abort()
-    } else {
-      observer?.(DownloadEvent.onFileDownloadError, {
-        fileName,
-        error: 'aborted',
-      })
     }
+
+    const downloadInfo = DownloadManager.instance.downloadInfo[fileName]
+    observer?.(DownloadEvent.onFileDownloadError, {
+      ...downloadInfo,
+      fileName,
+      error: 'aborted',
+    })
   }
 
   resumeDownload(observer: any, fileName: any) {

diff --git a/core/src/node/helper/download.ts b/core/src/node/helper/download.ts
@@ -8,8 +8,12 @@ export class DownloadManager {
 
   public static instance: DownloadManager = new DownloadManager()
 
+  // store the download information with key is model id
   public downloadProgressMap: Record<string, DownloadState> = {}
 
+  // store the download infomation with key is normalized file path
+  public downloadInfo: Record<string, DownloadState> = {}
+
   constructor() {
     if (DownloadManager.instance) {
       return DownloadManager.instance