Erase global_
by moving the modality to a [@globalized]
attribute
#93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erasing modalities can cause ppxs that inspect them to fail. Consider:
As written, this code compiles. If
global_
is completely erased,ppx_globalize
generates code that referencesA.globalize
(which does not exist). So we wish to tellppx_globalize
not to "re-globalize"a
when derivingB.globalize
without leaving theglobal_
modality in the record.ppx_globalize
already recognizes the[@globalized]
attribute for this purpose, so for now we rewriteglobal_
modalities to the[@globalized]
attribute when erasing extensions. Eventually, we will want to come up with a more general approach that all modes and ppxs can share and recognize.