Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more compatible with bleeding-edge-with-extensions & remove windows CI #87

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

ncik-roberts
Copy link

@ncik-roberts ncik-roberts commented Oct 24, 2024

A grab bag of fixes that allow the 5.2 version of bleeding-edge-with-extensions to build ocamlformat.

  • Switch CI to use 5.2 so I can switch to use Misc.Style instead of Misc.Color. This requires disabling windows CI, whose opam repository doesn't yet have 5.2. (Discussed with @ceastlund .)
  • Globalize a value that's stack-allocated under bleeding-edge-with-extensions
  • Eta-expand some functions to help the mode inference engine along
  • Fix a circular dependency in packages

@ncik-roberts ncik-roberts force-pushed the make-more-compatible-with-bleeding-edge branch from 46e6f41 to 417839c Compare October 31, 2024 20:04
@ncik-roberts ncik-roberts changed the title Make more compatible with bleeding-edge-with-extensions Make more compatible with bleeding-edge-with-extensions & remove windows CI Oct 31, 2024
Signed-off-by: Nick Roberts <[email protected]>
@ncik-roberts ncik-roberts force-pushed the make-more-compatible-with-bleeding-edge branch from 42c076d to d292628 Compare October 31, 2024 21:33
@ncik-roberts ncik-roberts merged commit b3617c6 into jane Nov 1, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants