Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for compressed output files, whether gzip (supported by Pe… #306

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

bnigito
Copy link
Contributor

@bnigito bnigito commented Oct 4, 2024

…rfetto) or zstd (not yet supported)

This builds on previous work for compressed file destinations

Closes #154

@bnigito bnigito force-pushed the compressed-file-output branch 2 times, most recently from b7fb091 to 8f3d722 Compare October 4, 2024 16:52
@Xyene Xyene force-pushed the compressed-file-output branch from 59a8208 to 0a3ae42 Compare October 4, 2024 19:36
@Xyene Xyene changed the title Add support for compressed output files, wither gzip (supported by Pe… Add support for compressed output files, whether gzip (supported by Pe… Oct 4, 2024
…erfetto) or zstd (not yet supported)

This builds on previous work for compressed file destinations

Closes janestreet#154

Signed-off-by: Brian Nigito <[email protected]>

Co-authored-by: Lidya Demilew <[email protected]>
Co-authored-by: Hao Lian <[email protected]>
Co-authored-by: Tudor Brindus <[email protected]>
@Xyene Xyene force-pushed the compressed-file-output branch from 0a3ae42 to 03fdd69 Compare October 4, 2024 19:38
Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xyene Xyene merged commit 7ac635e into janestreet:master Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressed trace files
2 participants