Skip to content

Commit

Permalink
Reap zombie perf processes from capability detection
Browse files Browse the repository at this point in the history
Closes #315.

Signed-off-by: Tudor Brindus <[email protected]>
  • Loading branch information
Xyene committed Nov 22, 2024
1 parent 48b61ef commit d36c159
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/perf_capabilities.ml
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ let detect_exn () =
let%bind perf_version_proc =
Process.create_exn ~prog:Env_vars.perf_path ~args:[ "--version" ] ()
in
let%map version_string = Reader.contents (Process.stdout perf_version_proc) in
let version = Version.of_perf_version_string_exn version_string in
let%map { stdout; _ } = Process.collect_output_and_wait perf_version_proc in
let version = Version.of_perf_version_string_exn stdout in
let set_if bool flag cap = cap + if bool then flag else empty in
empty
|> set_if (supports_configurable_psb_period ()) configurable_psb_period
Expand Down

0 comments on commit d36c159

Please sign in to comment.