Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use coveralls native golang support #89

Merged
merged 2 commits into from
Aug 19, 2024
Merged

use coveralls native golang support #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f92eec7
use coveralls native golang support
jandelgado Aug 19, 2024
15877ac
linter
jandelgado Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ on:
- master

env:
GO_VERSION: "1.22.4"
GO_LANG_CI_LINT_VERSION: "v1.59.1"
GO_VERSION: "1.22.5"
GO_LANG_CI_LINT_VERSION: "v1.60.1"

name: run tests
jobs:
Expand All @@ -35,7 +35,7 @@ jobs:
- name: create certificates
run: cd inttest/pki && ./mkcerts.sh
- name: Run RabbitMQ
run: cd inttest/rabbitmq && docker-compose up -d
run: cd inttest/rabbitmq && docker compose up -d
- name: Install Go
if: success()
uses: actions/setup-go@v4
Expand All @@ -46,13 +46,12 @@ jobs:
timeout 30 sh -c "while true; do curl -s http://guest:password@localhost:15672/api/exchanges/%2f/amq.topic && break || sleep 3; done"
- name: Run tests
run: make test
- name: Convert coverage.out to coverage.lcov
uses: jandelgado/gcov2lcov-action@v1
- name: Coveralls
uses: coverallsapp/github-action@v1.1.2
uses: coverallsapp/github-action@v2.3.0
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: coverage.lcov
file: coverage.out
format: golang
- name: Build release artifacts
if: env.build_artifacts # currently disabled
uses: goreleaser/goreleaser-action@v3
Expand Down
2 changes: 1 addition & 1 deletion cmd/rabtap/broker_info_renderer_dot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,6 @@ func (s *brokerInfoRendererDot) renderNode(n interface{}, queueRendered map[stri
// https://www.graphviz.org/doc/info/lang.html
func (s *brokerInfoRendererDot) Render(rootNode *rootNode, out io.Writer) error {
res := s.renderNode(rootNode, map[string]bool{})
fmt.Fprintf(out, res.Text)
fmt.Fprint(out, res.Text)
return nil
}
Loading