Make about dialog show up as fullscreen on iOS #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
force-pushed
the
iOS/fixAboutDlgOverflow
branch
from
62b64fa
to
b57a478
Compare
ann0see
changed the title
ann0see
added
iOS
ann0see
force-pushed
the
iOS/fixAboutDlgOverflow
branch
2 times, most recently
from
e4885e4
to
b5298af
Compare
Fixes an overflow bug for the about dialog on iOS. Related to: jamulussoftware#3343
ann0see
force-pushed
the
iOS/fixAboutDlgOverflow
branch
from
b5298af
to
16af636
Compare
|
Not sure if you can test this. But please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Fixes an UI overflow bug for the about dialog on iOS.
Related to: #3343
Now - with some potential device rotations the about dialog can be exited on Qt6:
CHANGELOG: CONDENSE WITH #3343
Context: Fixes an issue?
Related to: #3343
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Nothing
Checklist