Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump actions/checkout from 3 to 4 #3168

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2023

Bumps actions/checkout from 3 to 4.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

v3.0.1

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 4, 2023
@ann0see
Copy link
Member

ann0see commented Sep 14, 2023

We might need to update Linux builds soon too...

@pljones
Copy link
Collaborator

pljones commented Sep 18, 2023

Adding to 3.11.0

@pljones pljones added this to the Release 3.11.0 milestone Sep 18, 2023
@pljones
Copy link
Collaborator

pljones commented Oct 22, 2023

I don't seem to be able to rerun the fails.

@ann0see
Copy link
Member

ann0see commented Oct 22, 2023

@dependabot rebase

@ann0see
Copy link
Member

ann0see commented Oct 22, 2023

Maybe that kicks them again

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4 branch from 49f5a43 to 39eb6ec Compare October 22, 2023 18:19
@ann0see
Copy link
Member

ann0see commented Oct 24, 2023

We'll probably need to update node js somehow.

@pljones
Copy link
Collaborator

pljones commented Oct 25, 2023

Starting job container
/usr/bin/docker pull ubuntu:18.04

Maybe upgrading ubuntu to LTS 20.04?

@ann0see
Copy link
Member

ann0see commented Oct 25, 2023

I believe it led to the pan pots not showing up on Debian/Ubuntu.

@pljones
Copy link
Collaborator

pljones commented Oct 26, 2023

I build on LTS 22.04 locally - with Qt 5.15.3. I don't see any problems. With Qt6... well, keep well clear still.

@ann0see
Copy link
Member

ann0see commented Oct 26, 2023

I'm unsure how to proceed, as we might have strange sideeffects on older versions of Ubuntu - and we can't test them all. I think the artifacts are built using a lower Qt version

@pljones
Copy link
Collaborator

pljones commented Oct 27, 2023

We need to get off 18.04 anyway - it's out of support.
https://ubuntu.com/about/release-cycle

@ann0see
Copy link
Member

ann0see commented Nov 1, 2023

Hmm. Ok. I believe it's the same problem as we had with dropping Windows 7/8.1. Probably best to open a discussion. But if it's out of support, we should probably drop it

@softins
Copy link
Member

softins commented Feb 7, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4 branch from 39eb6ec to eda3a3f Compare February 7, 2024 18:15
@softins
Copy link
Member

softins commented Feb 7, 2024

This doesn't run on the Docker container for Ubuntu-18.04.

Updating autobuild.yml to use the container for Ubuntu-20.02 allows it to run, but the cross-compilation to ARM doesn't run. I'm currently working on finding out why.

@softins
Copy link
Member

softins commented Feb 9, 2024

This doesn't run on the Docker container for Ubuntu-18.04.

Updating autobuild.yml to use the container for Ubuntu-20.02 allows it to run, but the cross-compilation to ARM doesn't run. I'm currently working on finding out why.

There were a few other changes required, which I have as separate commits on https://github.com/softins/jamulus/tree/test-ubuntu

  • Update autobuild.yml to use ubuntu:20.04 as the building container, as mentioned above
  • Update .github/autobuild/linux_deb.sh to specify GCC as version 9
  • Update linux/debian/rules to use the native qmake, and correct DEB_TARGET_GNU_TYPE to DEB_HOST_GNU_TYPE, which was incorrect due to confusing GNU terminology.

With the above changes, the build is green for all targets. See https://github.com/softins/jamulus/actions/runs/7843432263

@ann0see
Copy link
Member

ann0see commented Feb 9, 2024

@softins thanks! If I find some time, I'll have a look at this (hopefully).

@softins softins mentioned this pull request Feb 10, 2024
5 tasks
@softins
Copy link
Member

softins commented Feb 10, 2024

This PR will be safe to apply after #3229 has been approved and merged.

@softins
Copy link
Member

softins commented Mar 4, 2024

@dependabot rebase

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4 branch from eda3a3f to d911b0e Compare March 4, 2024 12:52
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds succeeded - approving.

@ann0see ann0see merged commit 60287a4 into main Mar 4, 2024
14 checks passed
@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-4 branch March 4, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants