Add team id to macOS notarization action #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lando/notarize-action uses notarytool instead of the deprecated altool by default. Therefore the team id needs to be provided. Set it as GitHub secret.
ann0see
added
dependencies
softins
approved these changes
Aug 26, 2023
pljones
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
lando/notarize-action uses notarytool instead of the deprecated altool by default. Therefore the team id needs to be provided.
CHANGELOG: SKIP
Context: Fixes an issue?
Hopefully fixes the broken notarization on emlynmacs' repo. I can't test it.
Does this change need documentation? What needs to be documented and how?
NO
Status of this Pull Request
Ready for merging.
What is missing until this pull request can be merged?
Nothing.
/
Checklist