Acknowledge JACK #3109
Merged
Acknowledge JACK #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
reviewed
Jul 22, 2023
mcfnord
reviewed
Jul 22, 2023
ann0see
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Add a line to
README.mdacknowledging JACK (as it was the first audio interface library in use in Jamulus, it only seems fair).CHANGELOG: SKIP
Context: Fixes an issue?
n/a
Does this change need documentation? What needs to be documented and how?
n/a
Status of this Pull Request
See https://github.com/pljones/jamulus/tree/add-jack-ack
What is missing until this pull request can be merged?
Needs review and comments.
Checklist