Sourcery refactored master branch #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| @@ -22,7 +22,6 @@ | |||
| agents = pickle.load(open(AGENT_DATASET_LOCATION, 'rb')) | |||
| except TypeError: | |||
| raise Warning("User-Agent dataset cannot be found! Make sure that AGENT_DATASET_LOCATION is set.") | |||
| agents = [] | |||
There was a problem hiding this comment.
Lines 25-25 refactored with the following changes:
- Remove unreachable code (
remove-unreachable-code)
Comment on lines
-52
to
+59
| candidates = [] | ||
| for agent in agents: | ||
| if agent['regex'].match(user_agent_string): | ||
| candidates.append(agent) | ||
| candidates = [ | ||
| agent for agent in agents if agent['regex'].match(user_agent_string) | ||
| ] | ||
|
|
||
| start = time.time() | ||
| candidates.sort(key=lambda x: len(x['name'])) | ||
|
|
||
| start = time.time() | ||
| result = get_user_agent_characteristics(candidates[-1]) | ||
| return result | ||
| return get_user_agent_characteristics(candidates[-1]) |
There was a problem hiding this comment.
Function detect_user_agent refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| candidates = [] | ||
| for agent in agents: | ||
| if agent['regex'].match(user_agent_string): | ||
| candidates.append(agent) | ||
|
|
||
| candidates = [ | ||
| agent for agent in agents if agent['regex'].match(user_agent_string) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Function all_possible_matches refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!