Migrate static assets to embed.FS #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML templates and static files were embedded in the binary using go-bindata. As of Go 1.16, the new embed package can perform the same thing natively without needing extra tooling. Everything which referenced a static asset now does so using an embed.FS. This allowed simplifying quite a bit of the code handling that as it's now much more straightforward to handle thanks to the FS interface. The html/template package can parse embed.FS and net/http can serve it straight as a FileServer. The minimum Go version required now is 1.16, reflected in go.mod. The Makefile is now no longer really needed, but the sample-data target is useful, so it's been left in place along with a target for building the binary, but the README now says to use go build instead of make. Vendored dependencies are updated along with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML templates and static files were embedded in the binary using
go-bindata.
As of Go 1.16, the new embed package can perform the same thing natively
without needing extra tooling.
Everything which referenced a static asset now does so using an
embed.FS. This allowed simplifying quite a bit of the code handling that
as it's now much more straightforward to handle thanks to the FS
interface. The html/template package can parse embed.FS and net/http can
serve it straight as a FileServer.
The minimum Go version required now is 1.16, reflected in go.mod.
The Makefile is now no longer really needed, but the sample-data target
is useful, so it's been left in place along with a target for building
the binary, but the README now says to use go build instead of make.
Vendored dependencies are updated along with this.