Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As we discussed earlier, here is a PR to upgrade to
elm/http >= 2.0.0
and to address some of the concerns expressed in #42In particular:
send*
functions now emit anCmd msg
Http.request
method fromelm/http
(for examplegraphQLBody
andgraphQLexpect
)Result
type, that is a sort of three-state type, that carries the success or failure state without the need to double examine the result to get if the error is http-related or graphql-relatedWhat is missing is to update the documentation (indeed,
elm make --doc=out.json
fails). Let us know what do you think of the changes we've done so far and we will gladly update also the docs 😊