-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix background for android 8+ #64
base: master
Are you sure you want to change the base?
Conversation
This fix crashes the app when the background task starts on Android for me. Besides the crash, I had to update SDK version in gradle to make it see The logcat error when it crashes:
EDIT |
wow, thank you to find it out! I'll look what to do here |
@clytras can you say pls, what SDK you was have to update? Didn't meet that problem |
Of course. It wouldn't compile when running EDIT
|
@clytras I hope now it'll work just fine. For me, on the emulator, it doesn't send this error. Please, let me know if you face some other problems here |
Hello @EJohnF I tested in real device Galaxy J2 Core SM-J260F - 8.1.0 and it's working fine |
unfortunately it crashed after job executed |
This fix working fine on Xiaomi Redmi 6A - 8.10 |
This is working fine on my Xiaomi mi5 too, Android 8.0.0 |
Is there any progress on this. Is it going to be merged? |
This is approved but not merged. Is there a reason for this @mkamals @jamesisaac? Is the project still maintained? |
@clytras @EJohnF even when using EJohnF's fork with the fix I get the issue that the
But the react native debugger doen't show that it was reactivated and the Storage is empty and the notification is not shown. My setup is currently being tested on Android (Oneplus 5t) with:
Any ideas what the problem could be? Would be super grateful for any advice since this is very important for me :) |
fix for #63
the solution is taken from this discussion vikeri/react-native-background-job#71 and this PR vikeri/react-native-background-job#73