Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 🙂
According to https://www.rubydoc.info/gems/activerecord/ActiveRecord/Reflection/AbstractReflection
"Countable" associations are :
The current AssociationCountLoader works for has_many associations, but not for the other 2.
I added an implementation for habtm/has_many through which relies on
joins
with the association name (which should automatically go through all intermediate associations) +where
with association name: primary key => array of primary keys (which should automatically create the where clause).It also relies on an
inverse_of
definition, inspired by activerecord-precounter gem. I also added two errors (also inspired from the gem) in case of missing inverse_of, or in case of unhandled association.Note: the activerecord-precounter gem also handles association scopes, which could be added to this loader.