Skip to content

Commit

Permalink
Don't use AutoUnmount in FUSE integration tests
Browse files Browse the repository at this point in the history
It's the wrong thing to do: the FUSE session is unmounted automatically
when the BackgroundSession drops. AutoUnmount is for the case when the
mounting process might not unmount on its own, but we always do. Using
the option spawns a new thread and leaks a socket until the end of the
process, which means our test processes can run out of open file
descriptors if they run many FUSE sessions.

Signed-off-by: James Bornholt <[email protected]>
  • Loading branch information
jamesbornholt committed Apr 10, 2024
1 parent 2f2884b commit 2447a20
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion mountpoint-s3/tests/common/fuse.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ where
MountOption::DefaultPermissions,
MountOption::FSName("mountpoint-s3".to_string()),
MountOption::NoAtime,
MountOption::AutoUnmount,
MountOption::AllowOther,
];

Expand Down

0 comments on commit 2447a20

Please sign in to comment.