Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lightning node simulation activity designer #868

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Extheoisah
Copy link

@Extheoisah Extheoisah commented Apr 3, 2024

Closes #829

Still a WIP

Description

This PR enables a user to automate lightning payment simulations between nodes (limited to LND and c-lightning ATM).

Tasks

  • add simulation activity designer UI
  • programmatically create and save simulation activity to network.json file
  • programmatically create and save sim.json config file needed to run simulation
  • map docker volumes for simln docker container
  • start and stop a simulation
  • add simulation status indicator UI for running nodes
  • add simulation logger or output simulation file (e.g. sim-result.json) for users to download
  • add unit and e2e tests for simulation

Known Bugs/Issues

  • simln docker container sometimes doesn't pick up the tls cert of nodes in the network update: Fixed

@Extheoisah Extheoisah marked this pull request as draft April 3, 2024 21:22
@jamaljsr
Copy link
Owner

jamaljsr commented Apr 7, 2024

Hey @Extheoisah thanks for opening this draft PR. Please tag me as a reviewer when you are ready for me to take a look at it.

@Extheoisah Extheoisah force-pushed the add-simln-activity-designer branch from d091e7d to 825123c Compare May 28, 2024 18:48
@Extheoisah
Copy link
Author

Hey @Extheoisah thanks for opening this draft PR. Please tag me as a reviewer when you are ready for me to take a look at it.

Sorry for responding to this message late. I should have finalized this a while ago but I kept finding ways to add features (which broke things) instead of pushing the MVP among other commitments.
I have stashed those changes and will be pushing just the sim feature in a bit. Due to the rebase, I'm having some issues running the sim which I'm fixing.
I'll tag you when that's done.

@Extheoisah Extheoisah marked this pull request as ready for review June 12, 2024 07:08
@Extheoisah
Copy link
Author

@jamaljsr This is ready for first-pass review. You'd notice some of the tests are broken but I'm working to fix them and add a new test for the newly added activity designer. Aside from that, the MVP features are in place and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: proposed integration of sim-ln in polar
3 participants