Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for relative battery scale and set limit for battery arc #335

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Kampi
Copy link
Collaborator

@Kampi Kampi commented Aug 4, 2024

No description provided.

@Kampi Kampi requested a review from jakkra August 4, 2024 13:30
@jakkra
Copy link
Owner

jakkra commented Aug 4, 2024

Can't we do a setting instead? I'd prefer having as much as possible in runtime?

Can do like this

@Kampi
Copy link
Collaborator Author

Kampi commented Aug 4, 2024

Can't we do a setting instead? I'd prefer having as much as possible in runtime?

Can do like this

Yeah of course.

Copy link
Owner

@jakkra jakkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works :)

app/prj.conf Show resolved Hide resolved
app/src/applications/settings/settings_app.c Outdated Show resolved Hide resolved
@Kampi Kampi marked this pull request as ready for review August 6, 2024 07:49
@Kampi Kampi merged commit a93168a into jakkra:main Aug 6, 2024
13 checks passed
@Kampi Kampi deleted the Change-Battery-Scale branch August 6, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants