Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "all" and "pdg" to be round modes instead of ndigits. #188

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

jagerber48
Copy link
Owner

Addresses #185. Removes the "all" and "pdg" ndigits options and adds them as round_mode options.

@jagerber48 jagerber48 linked an issue Oct 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fdb667) to head (773fb7a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1174      1171    -3     
=========================================
- Hits          1174      1171    -3     
Flag Coverage Δ
3.10 100.00% <100.00%> (ø)
3.11 100.00% <100.00%> (ø)
3.12 100.00% <100.00%> (ø)
3.8 100.00% <100.00%> (ø)
3.9 100.00% <100.00%> (ø)
feature 93.90% <90.00%> (-0.02%) ⬇️
unit 63.91% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jagerber48 jagerber48 merged commit bb6f343 into main Oct 29, 2024
8 checks passed
@jagerber48 jagerber48 deleted the 185-rounding-configuration-v2 branch October 29, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding configuration
1 participant