Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link any residues #29

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Link any residues #29

wants to merge 13 commits into from

Conversation

js1710
Copy link
Collaborator

@js1710 js1710 commented Feb 25, 2019

Added more general support for multi-residue molecules. Currently only works for one molecule and cannot use itps as input.

js1710 added 13 commits December 19, 2018 19:24
@js1710
first commit. The linking of residues is not fully implemented.
ee67c5d
@js1710
first commit. The linking of residues is not fully implemented.
655c6d7
@js1710
Now can connect residues using the [ global ] section. Will only work…
26ce80d 
… for one molecule in water at the moment
@js1710
Updated documentation
a9d67ad
@js1710
Fixed multiple bugs in the output of multi-residue information. At th…
a67d29e 
…e moment only one multi-residue molecule is supported.
@js1710
updated tests
2dfa5cd
@js1710
Global section removed. Now can enter inter residue connections under…
e51667c 
… a molecule section [< mol >] and the name used for mol will apper in the itp file.
@js1710
updated inter residue test files
4ad9e90
@js1710
updated all bonset workflow to go via Molecule objects. Added test fo…
87820c3 
…r multi residue molecule itp output
@js1710
fixed bug in previous commit
0ff2ca4
@js1710
refactored output to make more streamlined for molecules with any num…
bec6af4 
…ber of residues
@js1710
removed any overlap between Molecule instances and Bead instances
46ab34e
@js1710
updated documentation
dfadc0a
@js1710 js1710 requested a review from jag1g13 February 25, 2019 12:28
jag1g13
jag1g13 reviewed Feb 25, 2019
View reviewed changes
Copy link
Owner

@jag1g13 jag1g13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple of places I'd like to do a little bit of rearrangement before this gets merged, but generally happy. The tests will make it much easier to do the rearrangements without having to worry too much about whether I've broken anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jag1g13 jag1g13 jag1g13 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js1710 @jag1g13