Added unit tests for the create.sh script

[asimchoudhary]

Which problem is this PR solving?

• Subpart of the Add REPLICATION parameter to Cassandra schema script #6582

Description of the changes

• created unit tests for the create.sh file , to test for various cases such as presence of Mode parameter , output for specific parameters

How was this change tested?

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: npm run lint and npm run test

[yurishkuro]

🚀

[yurishkuro]

It doesn't look like the test is being run in the CI, I only see compute-tags test being run.

https://github.com/jaegertracing/jaeger/actions/runs/12915527527/job/36017583978?pr=6594#step:8:1

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (3222e01) to head (b1b85fe).
Report is 4 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6594      +/-   ##
==========================================
+ Coverage   96.21%   96.24%   +0.02%     
==========================================
  Files         375      377       +2     
  Lines       21397    21421      +24     
==========================================
+ Hits        20588    20617      +29     
+ Misses        616      612       -4     
+ Partials      193      192       -1     

Flag	Coverage Δ
badger_v1	10.63% <ø> (ø)
badger_v2	2.78% <ø> (ø)
cassandra-4.x-v1-manual	16.64% <ø> (ø)
cassandra-4.x-v2-auto	2.72% <ø> (ø)
cassandra-4.x-v2-manual	2.72% <ø> (ø)
cassandra-5.x-v1-manual	16.64% <ø> (ø)
cassandra-5.x-v2-auto	2.72% <ø> (ø)
cassandra-5.x-v2-manual	2.72% <ø> (ø)
elasticsearch-6.x-v1	20.44% <ø> (ø)
elasticsearch-7.x-v1	20.51% <ø> (ø)
elasticsearch-8.x-v1	20.66% <ø> (ø)
elasticsearch-8.x-v2	2.77% <ø> (-0.01%)	⬇️
grpc_v1	12.20% <ø> (+<0.01%)	⬆️
grpc_v2	9.06% <ø> (ø)
kafka-3.x-v1	10.36% <ø> (ø)
kafka-3.x-v2	2.78% <ø> (ø)
memory_v2	2.78% <ø> (ø)
opensearch-1.x-v1	20.56% <ø> (ø)
opensearch-2.x-v1	20.56% <ø> (+<0.01%)	⬆️
opensearch-2.x-v2	2.78% <ø> (ø)
tailsampling-processor	0.51% <ø> (ø)
unittests	95.10% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

.github/workflows/ci-lint-checks.yaml
119:        SHUNIT2=.tools/shunit2 bash scripts/utils/compute-tags.test.sh

Let's create a single wrapper scripts/utils/run-tests.sh and call it from the workflow, and inside that script call individual scripts.

I prefer not to use auto-discovery (like *.test.sh) in case we change the naming or move stuff.

[asimchoudhary]

On it !

[asimchoudhary]

@yurishkuro sir , is there a way to run the ci pipeline (ci-lint-checks.yaml) on my forked version ?
i want to test the changes before raising the pr

[yurishkuro]

I don't think you can run the actual workflow, but you can run individual commands from it

[asimchoudhary]

@yurishkuro sir , can you please review the changes and give me feedback.

[yurishkuro]

if there are changes needed to this file it should be in one line, not across the whole file. Please revert.