Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change model.ToOTELxxxID() to accept ID argument #6589

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jan 22, 2025

Which problem is this PR solving?

Description of the changes

  • If we move TraceID/SpanID types to jaeger-idl we will not be able to define methods on them, so change to plain functions.

How was this change tested?

  • CI

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (08af186) to head (7d70fb8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6589      +/-   ##
==========================================
+ Coverage   96.21%   96.25%   +0.03%     
==========================================
  Files         375      375              
  Lines       21397    21397              
==========================================
+ Hits        20588    20596       +8     
+ Misses        616      610       -6     
+ Partials      193      191       -2     
Flag Coverage Δ
badger_v1 10.63% <20.00%> (ø)
badger_v2 2.78% <20.00%> (ø)
cassandra-4.x-v1-manual 16.64% <20.00%> (ø)
cassandra-4.x-v2-auto 2.72% <20.00%> (ø)
cassandra-4.x-v2-manual 2.72% <20.00%> (ø)
cassandra-5.x-v1-manual 16.64% <20.00%> (ø)
cassandra-5.x-v2-auto 2.72% <20.00%> (ø)
cassandra-5.x-v2-manual 2.72% <20.00%> (ø)
elasticsearch-6.x-v1 20.44% <20.00%> (+<0.01%) ⬆️
elasticsearch-7.x-v1 20.50% <20.00%> (-0.01%) ⬇️
elasticsearch-8.x-v1 20.67% <20.00%> (ø)
elasticsearch-8.x-v2 2.89% <20.00%> (+0.11%) ⬆️
grpc_v1 12.20% <20.00%> (+<0.01%) ⬆️
grpc_v2 9.06% <20.00%> (+<0.01%) ⬆️
kafka-3.x-v1 10.36% <20.00%> (ø)
kafka-3.x-v2 2.78% <20.00%> (ø)
memory_v2 2.78% <20.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 20.55% <20.00%> (-0.01%) ⬇️
opensearch-2.x-v1 20.55% <20.00%> (-0.01%) ⬇️
opensearch-2.x-v2 2.78% <20.00%> (ø)
tailsampling-processor 0.51% <0.00%> (ø)
unittests 95.11% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit cbad04b into jaegertracing:main Jan 22, 2025
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants