[storage]Upgraded integration tests to use Dependency Writer of storage_v2 #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orage_v2 Signed-off-by: Manik2708 <[email protected]>
|
I am little confused on the usage of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6559 +/- ##
==========================================
+ Coverage 96.21% 96.24% +0.02%
==========================================
Files 373 373
Lines 21400 21406 +6
==========================================
+ Hits 20591 20602 +11
+ Misses 616 612 -4
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manik2708
changed the title
yurishkuro
approved these changes
Jan 18, 2025
yurishkuro
added
the
changelog:ci
6 tasks
4 tasks
Manik2708
added a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 21, 2025
…ge_v2 (jaegertracing#6559) <!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? Fixes a part of: jaegertracing#6366 ## Description of the changes - Upgared the integration tests ## How was this change tested? - e2e tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Manik2708 <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
yurishkuro
pushed a commit
that referenced
this pull request
Jan 21, 2025
## Which problem is this PR solving? A minor fix related to #6559 ## Description of the changes - On addition of dependency writer in storage v2, mocks generation was left which is generating mocks when `make generate mocks` is ran on main branch which can cause unnecessary noise in a PR which is adding mocks ## How was this change tested? - unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes a part of: #6366
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test