Refactor collector pipeline to allow v1/v2 data model #6484
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6484 +/- ##
=======================================
Coverage 96.28% 96.29%
=======================================
Files 371 372 +1
Lines 21251 21277 +26
=======================================
+ Hits 20462 20489 +27
+ Misses 604 603 -1
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
|
@mahadzaryab1 PTAL |
| @@ -81,7 +81,7 @@ func (w *traceWriter) WriteTraces(ctx context.Context, td ptrace.Traces) error { | |||
| scope ptrace.ScopeSpans | |||
| resource ptrace.ResourceSpans | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
I've been running into this too when running make fmt. I'm not sure why CI doesn't complain but it gets fixed when running make fmt locally.
There was a problem hiding this comment.
We may have lost this in some refactoring. We do have linters (e.g. ./scripts/lint/updateLicense.py) that can modify the files and then fail if there were changes. We could have the same with a lint step that runs make fmt and fails if there's a diff.
…6484) ## Which problem is this PR solving? - Part of jaegertracing#6474 ## Description of the changes - Extend SpanProcessor interface to carry either v1 or v2 spans ## How was this change tested? - CI --------- Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: adityachopra29 <[email protected]>
Which problem is this PR solving?
Description of the changes
How was this change tested?