Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags with default variables for autoscaling and batch version #2768

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chlunde
Copy link
Contributor

@chlunde chlunde commented Dec 16, 2024

Which problem is this PR solving?

If these valuese are not initialized, the generator code will produce
invalid kubernetes objects when generating manifest files.

In operator mode, the default values were automatically detected.

Fixes #2767

Description of the changes

Set default flag values

How was this change tested?

  • go run . generate --cr in.yaml # check apiVersion for CronJob and HPA
  • make test

Checklist

If these valuese are not initialized, the generator code will produce
invalid kubernetes objects when generating manifest files.

In operator mode, the default values were automatically detected.

Signed-off-by: Carl Henrik Lunde <[email protected]>
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.73%. Comparing base (e4536a8) to head (110b03a).

Files with missing lines Patch % Lines
pkg/cmd/start/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2768      +/-   ##
==========================================
- Coverage   74.74%   74.73%   -0.02%     
==========================================
  Files         124      124              
  Lines       10497    10499       +2     
==========================================
  Hits         7846     7846              
- Misses       2454     2456       +2     
  Partials      197      197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: missing apiVersion for CronJob and HorizontalPodAutoscaler in generate mode
1 participant