Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing container security context settings and tests #2354

Merged
merged 2 commits into from
Nov 28, 2023
Merged

add missing container security context settings and tests #2354

merged 2 commits into from
Nov 28, 2023

Conversation

tingeltangelthomas
Copy link
Contributor

@tingeltangelthomas tingeltangelthomas commented Nov 8, 2023

Which problem is this PR solving?

Description of the changes

  • This PR adds container securityContext settings to several kubernetes templates

How was this change tested?

  • added and ran unittests for each change
  • installed operator to my EKS cluster and created Jaeger instance in a restricted namespace
  • executed make lint test

Checklist

Sorry, something went wrong.

Copy link

openshift-ci bot commented Nov 8, 2023

Hi @tingeltangelthomas. Thanks for your PR.

I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Signed-off-by: Thomas Kraus <[email protected]>
@iblancasa iblancasa self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a5b3f3) 87.69% compared to head (bd165f2) 87.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2354   +/-   ##
=======================================
  Coverage   87.69%   87.70%           
=======================================
  Files         102      102           
  Lines        7257     7261    +4     
=======================================
+ Hits         6364     6368    +4     
  Misses        697      697           
  Partials      196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tingeltangelthomas
Copy link
Contributor Author

/retest-required

@tingeltangelthomas
Copy link
Contributor Author

Hi @iblancasa,
is there anything I can do to make the tests green?

/retest-required

@iblancasa
Copy link
Collaborator

/retest

Copy link

openshift-ci bot commented Nov 13, 2023

@tingeltangelthomas: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 0b93b31 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@iblancasa
Copy link
Collaborator

@rubenvp8510 can you take a look to this PR?

@iblancasa
Copy link
Collaborator

/restest

I think there si something going wrong in OpenShift with these changes.

@rubenvp8510
Copy link
Collaborator

/restest

I think there si something going wrong in OpenShift with these changes.

Yeah :/ or may be is just matter of update the E2Es,

@tingeltangelthomas
Copy link
Contributor Author

I'm a bit disappointed about openshift e2e tests.
Can we check if failures are related to my changes? Do I need to revert my changes and retest or is there an easier way?

Thank you!

@tingeltangelthomas
Copy link
Contributor Author

/retest

@iblancasa iblancasa merged commit 8290377 into jaegertracing:main Nov 28, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing SecurityContext in several Job Container spec
3 participants