-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing container security context settings and tests #2354
add missing container security context settings and tests #2354
Conversation
Hi @tingeltangelthomas. Thanks for your PR. I'm waiting for a jaegertracing member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Thomas Kraus <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
=======================================
Coverage 87.69% 87.70%
=======================================
Files 102 102
Lines 7257 7261 +4
=======================================
+ Hits 6364 6368 +4
Misses 697 697
Partials 196 196 ☔ View full report in Codecov by Sentry. |
/retest-required |
Hi @iblancasa, /retest-required |
/retest |
@tingeltangelthomas: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@rubenvp8510 can you take a look to this PR? |
/restest I think there si something going wrong in OpenShift with these changes. |
Yeah :/ or may be is just matter of update the E2Es, |
I'm a bit disappointed about openshift e2e tests. Thank you! |
…Context
/retest |
Which problem is this PR solving?
Description of the changes
How was this change tested?
make lint test
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test