Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger] Support gRPC storage in Jaeger >=1.60.0 #626

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

runderwo
Copy link
Contributor

@runderwo runderwo commented Jan 15, 2025

The keyword changed, so we have to carry the env vars with us in that case.

What this PR does

Allows gRPC storage to be used in newer jaeger-query releases when deployed with helm.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format,
will close that issue when PR gets merged)

  • fixes #

Checklist

  • DCO signed
  • Commits are GPG signed
  • Chart Version bumped
  • Title of the PR starts with chart name ([jaeger] or [jaeger-operator])
  • README.md has been updated to match version/contain new values

The keyword changed, so we have to carry the env vars with us
in that case.

Signed-off-by: Ryan Underwood <[email protected]>
@runderwo runderwo changed the title Support gRPC storage in Jaeger >=1.60.0 [jaeger] Support gRPC storage in Jaeger >=1.60.0 Jan 15, 2025
@pavelnikolov pavelnikolov merged commit ba67df8 into jaegertracing:main Jan 15, 2025
1 check passed
@runderwo
Copy link
Contributor Author

Not sure what happened, but the chart version update didn't make it into the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants