Skip to content

Commit

Permalink
Add validation of new protoc against Jaeger repos (#39)
Browse files Browse the repository at this point in the history
* Add validation of new protoc against Jaeger repos

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Jun 29, 2024
1 parent 45c86d9 commit c0ecd91
Showing 1 changed file with 40 additions and 7 deletions.
47 changes: 40 additions & 7 deletions .github/workflows/build-and-publish.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
name: Docker Image
on:
push:
tags:
- '**'
branches:
- main
branches: [main]
pull_request:
branches: [main]
paths:
- .github/workflows/jaeger-dockerimage.yml
- Dockerfile
- protoc-wrapper
- .github/workflows/jaeger-dockerimage.yml
- Dockerfile
- protoc-wrapper
release:
types: [published]
# allow running release workflow manually
workflow_dispatch:

jobs:
build:
Expand Down Expand Up @@ -56,3 +58,34 @@ jobs:
cache-from: type=gha
cache-to: type=gha,mode=max
platforms: linux/amd64,linux/arm64

# The following steps run only on pull requests and validate
# that the new image can run successfully in Jaeger repos.
# We do not check if the generated files would be different there,
# only that the build does not fail.

- name: Checkout Jaeger for validation
if: github.event_name == 'pull_request'
uses: actions/checkout@v4
with:
repository: jaegertracing/jaeger
submodules: recursive
path: jaeger

- name: Build Proto in Jaeger
if: github.event_name == 'pull_request'
working-directory: jaeger
run: make proto JAEGER_DOCKER_PROTOBUF=protobuf

- name: Checkout jaeger-idl for validation
if: github.event_name == 'pull_request'
uses: actions/checkout@v4
with:
repository: jaegertracing/jaeger-idl
submodules: recursive
path: jaeger-idl

- name: Build Proto in jaeger-idl
if: github.event_name == 'pull_request'
working-directory: jaeger-idl
run: make proto PROTOC_IMAGE=protobuf

0 comments on commit c0ecd91

Please sign in to comment.