Change Artists list behavior #571
Conversation
Modify artist request to supply real artist list Modify artist viewer to request artist from artist uri Changes to be committed: modified: src/js/services/google/middleware.js modified: src/js/services/mopidy/middleware.js modified: src/js/store/index.js
|
Can you please provide background to this change? What is the need for this change, especially when the value can be changed in the UI, per user? |
|
Hello James, You right, it miss background a bit. I use mopidy/Iris only with local files and i simply wanted to see the full list of artists. As the db seem to be contain the full list of artist, i expected that iris do it as well. I didn't know that this setting could be change from UI. I guess, you are talking about the artist library URI that can be set in the settings page ? I try to changed it, but i was not able to figure out how to make it work. But i'm a bit confused because it seem to me, that those values are hardcoded, can you correct me were i'm wrong ? If it is possible to change this setting from the UI, you can close and forget the PR and i apologize for my mistake |
|
I think you might find that you've stumbled upon a bug. When changing the setting in the UI (Settings > Advanced > Library Artists URI) and refreshing your browser, is your change retained? |
|
You're right, apparently changes does not seem retained. I will try to understand why and I will keep you inform. |
* Display general Spotify error messages that are provided by API * Calculating group volume on render rather than on load, fixes jaedb#534 * Removing group when last client is removed from it * Properly cancellable processes; Playlists that refuse to load tracks * Removing data_dir in favor of Extension.get_data_dir, jaedb#547 * Creating SearchResults component * Search results grid layout; Tracklist * Clearable search results * Ditching thumbnail glow on mobile - performance suffering too much * Play/queue actions on playlist save tracks to index for faster reuse * Fixing context menu trigger silencing; Search form polish * Letter spacing * Fixing theme tweaks; Fixing prefers-color-scheme of false, resolves jaedb#549 * Buildout * Black and flake fixups (still no check_manifest working reliably) * Removing old helpers * Fill prop for thumbnails on Queue and Artist for large screens * Getting a feel for desired multi-language approach jaedb#424 * Language as window.language for access in pure function * Exposing components for translation mapping; Queue and AAlbum views now moved to translation file * Renaming Content to I18n to avoid naming clashes; Artist and Debug views mapped * Mapping Playlist view * Clickable flags; Adding links to version release notes * Merging into main dev stream * Mapping all remaining views - just modals and components to go * All views done this time; Language file mapping for modals.. Will need to do destructuring in second sweep * Halfway through modals mapping * Final components done, dynamic language selector * Adding error boundary around Notifications to catch issues like jaedb#565 * Responsive for < 350px devices, fixes jaedb#532 * Prod buildout * Correcting snapcast config and path * Updating with corrected Snapserver config file path * Mobile polish; Performance experimentation; Loader screen; ; Minor code bugs * Previewing items to add, in prep for random selection (jaedb#546) * Fixing library URI setting (destructuring), possibly related to jaedb#571 * Adding generic loadItem (refactor elsewhere); Adding foundation for Add Random * Modal detection through less-than-ideal jQuery * Add to queue random functional * Adding jest coverage * Added sv.yaml This is the first version of a Swedish translation for Iris. * Upgrading jest * Add German translations * Upgrading to Babel 7; Fixing failing tests * Disable lifecycle methods * Buildout * 3.51 buildout * Adding jest to ci jobs * Adding Code Climate coverage reporter Co-authored-by: James Barnsley <[email protected]> Co-authored-by: el97 <[email protected]> Co-authored-by: Fabian Dennler <[email protected]>
|
Thanks for your effort to create this code contribution. It has actually highlighted an oversight to consider the custom Library URI settings in this string replacement, so it'll require a bit more work at my end. |
* Display general Spotify error messages that are provided by API * Calculating group volume on render rather than on load, fixes jaedb#534 * Removing group when last client is removed from it * Properly cancellable processes; Playlists that refuse to load tracks * Removing data_dir in favor of Extension.get_data_dir, jaedb#547 * Creating SearchResults component * Search results grid layout; Tracklist * Clearable search results * Ditching thumbnail glow on mobile - performance suffering too much * Play/queue actions on playlist save tracks to index for faster reuse * Fixing context menu trigger silencing; Search form polish * Letter spacing * Fixing theme tweaks; Fixing prefers-color-scheme of false, resolves jaedb#549 * Buildout * Black and flake fixups (still no check_manifest working reliably) * Removing old helpers * Fill prop for thumbnails on Queue and Artist for large screens * Getting a feel for desired multi-language approach jaedb#424 * Language as window.language for access in pure function * Exposing components for translation mapping; Queue and AAlbum views now moved to translation file * Renaming Content to I18n to avoid naming clashes; Artist and Debug views mapped * Mapping Playlist view * Clickable flags; Adding links to version release notes * Merging into main dev stream * Mapping all remaining views - just modals and components to go * All views done this time; Language file mapping for modals.. Will need to do destructuring in second sweep * Halfway through modals mapping * Final components done, dynamic language selector * Adding error boundary around Notifications to catch issues like jaedb#565 * Responsive for < 350px devices, fixes jaedb#532 * Prod buildout * Correcting snapcast config and path * Updating with corrected Snapserver config file path * Mobile polish; Performance experimentation; Loader screen; ; Minor code bugs * Previewing items to add, in prep for random selection (jaedb#546) * Fixing library URI setting (destructuring), possibly related to jaedb#571 * Adding generic loadItem (refactor elsewhere); Adding foundation for Add Random * Modal detection through less-than-ideal jQuery * Add to queue random functional * Adding jest coverage * Added sv.yaml This is the first version of a Swedish translation for Iris. * Upgrading jest * Add German translations * Upgrading to Babel 7; Fixing failing tests * Disable lifecycle methods * Buildout * 3.51 buildout * Adding jest to ci jobs * Adding Code Climate coverage reporter Co-authored-by: James Barnsley <[email protected]> Co-authored-by: el97 <[email protected]> Co-authored-by: Fabian Dennler <[email protected]>
Modifying artist request to supply complete artist list
Modifying artist viewer to use artist's uri instead of albumartist's uri
Changes to be committed:
modified: src/js/services/google/middleware.js
modified: src/js/services/mopidy/middleware.js
modified: src/js/store/index.js