forked from LunarG/gfxreconstruct
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brad rebase and refactor fix for staging buffer memory types #1
Closed
bradgrantham-lunarg
wants to merge
10
commits into
jacobv-nvidia:fix-staging-buffer-memory-types
from
bradgrantham-lunarg:brad-tweak-1115
Closed
Brad rebase and refactor fix for staging buffer memory types #1
bradgrantham-lunarg
wants to merge
10
commits into
jacobv-nvidia:fix-staging-buffer-memory-types
from
bradgrantham-lunarg:brad-tweak-1115
Commits on May 8, 2023
-
Fix raytracing trim error in state tracking (LunarG#1114)
* Fix raytracing trim capture crash The commit fix raytracing trim capture crash issue for a d3d12 title. In trim handling of BuildRaytracingAccelerationStructure, some alias resource cause GetResourceWrapperForGpuVa return wrong resource and trigger GPU crash later, the commit fix the issue. * Add some changes to address review comments Remove default argument to use both GPUVA and buffer size for searching resource, add copyright info. * Add new functions to address review comments Add new functions for searching resource wrapper through GetAccelerationStructureResourceWrapperForGpuVa which return resource used for raytracing acceleration structure. * Add some changes for review comments Add resource desc struct in the ID3D12ResourceInfo so resource desc info can be used without injecting API call, remove GetAccelerationStructureResourceWrapperForGpuVa and combine its function into GetResourceWrapperForGpuVa. * Add some changes for source code optimization Change function names and optimize some source code to address review comments. * Add changes for GPUVA searching function Add changes for checking resource initial state to find matched acceleration structurer resouce, remove resource desc in resource info and also remove checking resource flags. * Change function pointer name Change function pointer name used for checking acceleration structure resource and add some other changes to address review comments. * Change function pointer type and parameter name Change function pointer tyoe and parameter name to more specific name and add some other code optimization changes. * Add some minor change Change function GetResourceWrapperForGpuVa parameter name to be more specific. * Add some change to address review comments Remove checking resource initial state in TrackBuildRaytracingAccelerationStructure method when searching GPUVA for D3D12_BUILD_RAYTRACING_ACCELERATION_STRUCTURE_INPUTS, remove unnecessary assert. --------- Co-authored-by: Zheng <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 95e6bf7 - Browse repository at this point
Copy the full SHA 95e6bf7View commit details
Commits on May 15, 2023
-
Update Help Output and USAGE File (LunarG#1112)
The problem The message is out of date. The solution Update the message.
Configuration menu - View commit details
-
Copy full SHA for b37c948 - Browse repository at this point
Copy the full SHA b37c948View commit details
Commits on May 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 29f06bf - Browse repository at this point
Copy the full SHA 29f06bfView commit details
Commits on May 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2d64c36 - Browse repository at this point
Copy the full SHA 2d64c36View commit details
Commits on May 25, 2023
-
Moved Containers out of OverrideQueuePresentKHR
Allocating the backing store for all these containers on every call to the function and then freeing it on every exit can be avoided by having them be member variables that are cleared on each call. At least for the vectors this should change their size but not their capacity, and thus not hitting the heap allocation functions once a steady state of reserved capacity is reached.
Configuration menu - View commit details
-
Copy full SHA for 5fb7273 - Browse repository at this point
Copy the full SHA 5fb7273View commit details
Commits on May 26, 2023
-
Add option GFXRECON_QUEUE_ZERO_ONLY
It forces to using only QueueFamilyIndex: 0 and queueCount: 1 on capturing to avoid replay error for unavailble VkQueue.
Configuration menu - View commit details
-
Copy full SHA for 8970faf - Browse repository at this point
Copy the full SHA 8970fafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10c11ec - Browse repository at this point
Copy the full SHA 10c11ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for edcce34 - Browse repository at this point
Copy the full SHA edcce34View commit details
Commits on May 29, 2023
-
* Annotate GPUVA Problem If a title updated DXR resource data by Shader and dispatch the shader at same commandlist as DXR call, GFXR was not able to read out the DXR data and patch it. Solution GFXR capturer annotates all GPUVA, GPU Descriptor Handle and ShaderID during capture, scans managed CPU memory and marks the data which have been annotated. When replay the trace file, GFXR only need to translate the marked value. Test If there were artifacts during capture, try to change the MASK of GPUVA by ENV. * Meger dev branch
Configuration menu - View commit details
-
Copy full SHA for dfbf66f - Browse repository at this point
Copy the full SHA dfbf66fView commit details
Commits on Jun 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3398c27 - Browse repository at this point
Copy the full SHA 3398c27View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.