Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to include additional headers in a search request #68

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

expressintegrations
Copy link
Contributor

This allows me to add headers such as {'searchPreferences': {'bodyFieldsOnly': False}} so that I can get a more detailed response back from the Search action.

My use case was getting the list of values back from a CustomList object. The only way to do that is to include those headers.

This allows me to add headers such as `{'searchPreferences': {'bodyFieldsOnly': False}}` so that I can get a more detailed response back from the Search action.

My use case was getting the list of values back from a CustomList object. The only way to do that is to include those headers.
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1d4332d) 35.81% compared to head (1f3e28b) 35.71%.
Report is 1 commits behind head on main.

Files Patch % Lines
netsuite/soap_api/client.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   35.81%   35.71%   -0.11%     
==========================================
  Files          25       25              
  Lines        1061     1064       +3     
==========================================
  Hits          380      380              
- Misses        681      684       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iloveitaly
Copy link
Collaborator

@expressintegrations thanks for the contribution! Can you update the PR to fix the style CI issues?

@expressintegrations
Copy link
Contributor Author

@iloveitaly Styles are fixed!

@iloveitaly iloveitaly merged commit 33e1cef into jacobsvante:main Dec 13, 2023
77 of 79 checks passed
@expressintegrations
Copy link
Contributor Author

@iloveitaly not sure what your CI/CD process looks like, anything I need to do to get the version updated on PyPI to include this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants