Skip to content

Commit

Permalink
use proper permissions path
Browse files Browse the repository at this point in the history
  • Loading branch information
jacob-8 committed Oct 23, 2023
1 parent 5e2e3da commit f750cda
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/component-tests_kitbook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

steps:
- name: Allow image commit and branch name extraction
run: git config --system --add safe.directory /__w/jacob-8/kitbook # --global might work instead of --system, https://github.com/actions/checkout/issues/1169
run: git config --system --add safe.directory /__w/kitbook/kitbook # --global might work instead of --system, https://github.com/actions/checkout/issues/1169

- name: Get Branch
uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/component-tests_template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

steps:
- name: Allow image commit and branch name extraction
run: git config --system --add safe.directory /__w/jacob-8/kitbook # --global might work instead of --system, https://github.com/actions/checkout/issues/1169
run: git config --system --add safe.directory /__w/kitbook/kitbook # --global might work instead of --system, https://github.com/actions/checkout/issues/1169

- name: Get Branch
uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions packages/kitbook/src/docs/7-visual-regression-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ You may also enjoy using the Playwright UI runner by adding the `--ui` flag to y

## Add GitHub Action

I run my component testing against actual Vercel deployment previews and the following workflow is an example of how to do that. But it's easy to adapt to other environments as all you need is to do is make sure the right url is passed to `PLAYWRIGHT_BASE_URL` or you can just start a dev server. Also change `jacob-8/kitbook` to your repo name.
I run my component testing against actual Vercel deployment previews and the following workflow is an example of how to do that. But it's easy to adapt to other environments as all you need is to do is make sure the right url is passed to `PLAYWRIGHT_BASE_URL` or you can just start a dev server. Also change `kitbook/kitbook` to your repo name (not `user/repo` but `repo/repo`).

```yaml title=".github/workflows/component-tests.yml"
name: Playwright Component Tests
Expand All @@ -97,7 +97,7 @@ jobs:

steps:
- name: Allow image commit and branch name extraction
run: git config --system --add safe.directory /__w/jacob-8/kitbook # --global might work instead of --system, https://github.com/actions/checkout/issues/1169
run: git config --system --add safe.directory /__w/kitbook/kitbook # --global might work instead of --system, https://github.com/actions/checkout/issues/1169

- name: Get Branch
uses: actions/checkout@v3
Expand Down

0 comments on commit f750cda

Please sign in to comment.