GSON global version (Gradle) #2305
Conversation
|
Thanks for your contribution, @JNightRider . A little history: the situation this PR addresses is a direct consequence of PR #2278, which was a temporary solution for a bug in PR #2060. Long term, it would be better to figure out why PR #2060 broke glTF importing and solve that issue, so we could go back to jme3-plugins not depending on the gson library at all. Such a solution would make this PR unnecessary. Furthermore, the current best practice for coding library versions in Gradle builds is not to hard-code them into common.gradle or other Gradle scripts, but instead to use a version catalog. If you want to simplify version upgrades, that would be a better way to go. |
|
Hi @stephengold Thanks for reviewing this PR...
You're right, I think it's the best option. I will do some research on that matter (this may take time)
It would be interesting to apply this in regards to how lwjgl3 and nifty are versioned (maybe with gson if the problem is still not resolved - PR #2060). I would like to implement it (if possible, I don't promise anything), this would change the main goal of this PR which is the gson version but it is still the same path. For now I'll leave this PR as a draft, as it may change... |
|
It would be cleaner to create 2 new PRs: one to create the version catalog and one to properly resolve the issue with PR #2060. |
|
There is a PR (#2311) that replaces this... |
It seems that the gson library is used by 2 modules:
jme3-plugins and jme3-plugins-json-gson, this can be tedious when gson has a new version and needs to be updated, it would have to be changed in 2 places (modules)This PR mainly changes the way the dependency is implemented, the version has been defined globally the same as with lwjgl3 (version)